[Feature] Optimize Add/RemoveRolesAsync methods
#2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csmir
approved these changes
Feb 26, 2023
3 tasks
Misha-133
added a commit
to Misha-133/Discord.Net
that referenced
this pull request
May 11, 2023
This reverts commit 11481a1.
csmir
pushed a commit
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks
AddRolesAsyncandRemoveRolesAsyncmethods to useModify Guild Memberendpoint instead of callingAdd Guild Member RoleandRemove Guild Member Rolefor each role, which greatly optimizes methods' performance with large role sets.