-
-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support for the new username system #2696
[Feature] Support for the new username system #2696
Conversation
Co-authored-by: Dmitry <dimson-n@users.noreply.github.com>
Might want to deprecate |
Bots will remain on the old username system |
Co-authored-by: Quin Lynch <49576606+quinchs@users.noreply.github.com>
Co-authored-by: Quin Lynch <49576606+quinchs@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update SocketThreadUser.DisplayName
to match SocketGuildUser.DisplayName
by including a nullability check with GlobalName
before Username
This PR brings support for the new username system introduced by discord.
Changes
ToString()
methods of user entities & their debugger display properties to use the new unique username instead ofusername#discriminator
pattern if discriminator value is equals to 0 - the placeholder value.discriminator
parameter ofBaseSocketClient.GetUser()
method optionalEmbedBuilderExtensions.WithAuthor()
MentionUtils
GlobalName
property to user entitiesUserTypeReader
inDiscord.Commands
to search forGlobalName
Misc
update
MentionUtils
to use<@id>
user mention syntax instead of deprecated<@!id>
(docs)closes [Bug]: New usernames are displayed with #0000 discriminator #2693
P.S. I think I've found all places that need to be updated for the new system, pls correct me if I missed any