[Fix]: Slash Command Localizations lost after AddCommandsToGuildAsync and deleteMissing = false #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetch localizations when adding commands with `deleteMissing` = `false` fixes #2757
|
I would suggest introducing optional localization parameter's rather than forcing true on the localization params. |
Yeah, could do that, but it is not clear for me what the use case of the current behavior is. |
quinchs
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fetch localizations when adding commands with
deleteMissing=falseto prevent them getting lost.Changes
withLocalizationsparameter with valuetrueto the calls toRestClient.GetGlobal/GuildApplicationCommandscalls.Related Issues