-
-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UpdateAsync Remove Attachment Bug #2766
Conversation
Not the best way, however, this has already been pushed awaiting review and merge #2753 |
Issue resolves another issue similar to #2753 and #2236. Tested changes and approve the changes within this PR. Can we get high priority on this for next release @Misha-133 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a FileAttachment
property to json model would not allow sending new attachments.
Same approach as in SocketMessageComponent should be used instead.
Additionally, RestMessageComponent.Update
should also be updated to allow setting Attachments
@Misha-133 Updated those functions and |
Description
This PR adds the ability to remove attachments for a
IModalInteraction
when callingUpdateAsync
.Changes
Attachments
object toInteractionCallbackData
.UpdateAsync
to addAttachments
object to bothRestModal
andSocketModal
.Related Issues