-
-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Add missing parameters to RespondWithModalAsync
methods and implement missing overloads
#2769
[Fix] Add missing parameters to RespondWithModalAsync
methods and implement missing overloads
#2769
Conversation
Could you also add this overload? |
should the |
Yeah, it should |
modifyModal
parameters to RespondWithModalAsync
methodsRespondWithModalAsync
methods
RespondWithModalAsync
methodsRespondWithModalAsync
methods and implement overloads
RespondWithModalAsync
methods and implement overloadsRespondWithModalAsync
methods and implement missing overloads
Description
This PR adds missing implementation of modal modification in module bases.
Changes
modifyModal
parameters to theRespondWithModalAsync<T>
methods. (b7ee974)RespondWithModalAsync<T>
overload to module bases. (e63665d)options
parameter in theRespondWithModalAsync
method. (46bcd72)IDiscordInteractionExtensions
by using themodalInfo.FromModal
method. (42f448b)RestInteractionModuleBase
by extracting aHandleInteractionAsync
method. (1a788d4)