[Fix] URL encode timestamps sent as query parameters #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Methods calling to the
threads/archived/*endpoints don't escape the '+' character in thebeforequery parameter, resulting in a DATE_TIME_TYPE_PARSE error. URL escaping the timestamp solves this.Changes
all threetwo of the archived thread enumeration methodsRelated Issues
none
EDIT: Sorry, I just realized one of these endpoints expects a different date format. Should have RTFM.
The other 2 methods are still in scope, reverted changes for the third one.
(The third method still seems to be incorrect in one of the branches, but that isn't related to this PR.)