Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Embed ToJsonString & (Try)Parse #2787

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

Misha-133
Copy link
Member

Description

This PR fixes issues related to IEmbed.ToJsonString & EmbedBuilder.(Try)Parse methods.
While moving (Try)Parse to a new class is technically a breaking change - these ones were broken since they've been implemented.

Changes

  • move (Try)Parse methods to EmbedBuilderUtils class
  • fix ToJsonString method

Related Issues

@Misha-133 Misha-133 merged commit 7b5c40a into discord-net:dev Oct 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Parse and ToJsonString from EmbedBuilder
2 participants