Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generic exceptions. #2913

Merged

Conversation

AnalogFeelings
Copy link
Contributor

Description

Removes instances of generic exceptions in the code.

Changes

  • Removes instances of the generic Exception class.
  • Removes weird return Task.Delay(0); in connection manager.

Related Issues

@AnalogFeelings
Copy link
Contributor Author

the reason its a draft is because I want feedback on any exceptions that should be changed :suspect:

@AnalogFeelings AnalogFeelings marked this pull request as ready for review April 23, 2024 00:30
@Misha-133 Misha-133 merged commit 54d2fe5 into discord-net:dev May 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not throw the basic Exception type
2 participants