Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Bypass for CanSendResponse #2932

Merged
merged 9 commits into from
May 16, 2024
Merged

Config Bypass for CanSendResponse #2932

merged 9 commits into from
May 16, 2024

Conversation

WhyNot180
Copy link
Contributor

Description

This adds an option in the config to easily bypass the internal time check on responses. This should be useful for use in a dev environment where latency issues are more prevalent.

This check is a little redundant, since Discord will refuse a late request anyways, but this should allow for a little more leeway without making too many changes.

Changes

  • Adds ResponseInternalTimeCheck bool to DiscordConfig and BaseDiscordClient
  • Adds check to each use of InteractionHelper.CanSendResponse

Related Issues

Copy link
Member

@Misha-133 Misha-133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Misha-133 Misha-133 enabled auto-merge (squash) May 16, 2024 21:25
@Misha-133 Misha-133 merged commit 9030a5b into discord-net:dev May 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Easy bypass for Defer 3 Second clock sync issue
2 participants