Add BaseSocketClient object. #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiscordSocketClient and DiscordShardedClient's shared members now exist in this abstract class.
Remove extraneous overloads.
Style cleanups.
Style cleanup.
Joe4evr
reviewed
Jul 28, 2017
| @@ -67,7 +67,7 @@ internal override void Dispose(bool disposing) | |||
|
|
|||
| public Task StartAsync() => _connection.StartAsync(); | |||
| public Task StopAsync() => _connection.StopAsync(); | |||
|
|
|||
There was a problem hiding this comment.
Wat.
(Same goes for the other line in this file.)
|
Remove all that superfluous whitespace ( |
|
Looks good, but maybe we can leave |
|
Sounds good to me. |
FiniteReality
pushed a commit
to FiniteReality/Discord.Net
that referenced
this pull request
May 5, 2018
* Add BaseDiscordClient. Add various missing RequestOptions args. DiscordSocketClient and DiscordShardedClient's shared members now exist in this abstract class. * Add ShardReady event. * Style consistency. Remove extraneous overloads. Remove extraneous overloads. * Add BaseSocketClient#DownloadUsersAsync(). Style cleanups. * Add ShardLatencyUpdated event. Style cleanup. * Hook LatencyUpdated for ShardedClient. * Begone whitespace. * I'm good at this, I swear. >_> * Add back DiscordShardedClient.UserPresenceUpdated * Add ObsoleteAttribute * Removing the UserPresenceUpdated event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes:
- Removed leftoverDiscordShardedClient.UserPresenceUpdatedevent.(Will be done on next major release)
Additions:
Minor:
-- Added optional RequestOptions argument that was missing from various methods.
-- Added docstrings for all events.
There is no currently existing bridge between DiscordSocketClient and DiscordShardedClient, leaving users to duplicate all websocket client functionality between the two if they wish to abstract code that should be shared to a BCL, or for addon developers that wish to support both client types out of the box.
While it makes logical sense that this wasn't implemented previously as DiscordShardedClient isn't technically a client itself, but a wrapper for multiple DiscordSocketClients, that comes at an unfortunate expense of usability for accessing events or methods only supported via websockets.