Changed Guild#DefaultChannel to resolve the first accessible channel #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #776 This change is inline with discord/discord-api-docs#329 RestGuild#DefaultChannelId is now obsolete and will throw a NotSupportedException.
FiniteReality
approved these changes
Aug 28, 2017
Adding an exception here would be a breaking change, so this was agreed to fall back to the previous behavior, which would just return the guild ID.
FiniteReality
pushed a commit
to FiniteReality/Discord.Net
that referenced
this pull request
May 5, 2018
…iscord-net#777) * Changed Guild#DefaultChannel to resolve the first accessible channel Resolves discord-net#776 This change is inline with discord/discord-api-docs#329 RestGuild#DefaultChannelId is now obsolete and will throw a NotSupportedException. * RestGuild#DefaultChannelId will fall back to the guild ID Adding an exception here would be a breaking change, so this was agreed to fall back to the previous behavior, which would just return the guild ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #776
Notable changes:
The above change has not been rolled out on Discord's backend yet, so this merge request will remain blocked until it can be tested.