Fix GuildPermission Modify, Add Missing Permission to AllowAll #866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was told (by
The Noodle Mummy#0339
andSpoopy Ghost Dog#5440
) of an issue withGuildPermissions#Modify
producing incorrect results. My discord handle isChrisJ#8703
.This code snippet:
Would produce this result (as seen in Audit Logs):
Now appears to be working correctly:
Problem was caused by a parameter (
manageRoles
) out of order inGuildPermissions
: https://github.com/RogueException/Discord.Net/blob/dev/src/Discord.Net.Core/Entities/Permissions/GuildPermissions.cs#L135In addition, I was also told that the following snippet:
would execute without problem, but was missing the WebHook permission. This is fixed in
ChannelPermissions
, and appears to be working properly now.