Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent NREs from occurring when sending/modifying messages #993

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Prevent NREs from occurring when sending/modifying messages #993

merged 1 commit into from
Mar 23, 2018

Conversation

Quahu
Copy link
Contributor

@Quahu Quahu commented Mar 23, 2018

Attempting to call

IMessageChannel#SendMesssageAsync()

while only specifying the embed, or modifying a message with a valid embed and content set to null throws a NullReferenceException. This PR prevents it from happening.

@foxbot foxbot merged commit 55299ff into discord-net:dev Mar 23, 2018
@Quahu Quahu changed the title Prevent NREs from occuring when sending/modifying messages Prevent NREs from occurring when sending/modifying messages Mar 24, 2018
FiniteReality pushed a commit to FiniteReality/Discord.Net that referenced this pull request May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants