-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Manual deletion of channel prevents tickets from closing. #276
Comments
I think it'd make more sense to just close the ticket if the channel is deleted. There is no point in having a ticket without channel. |
this, unless the bot makes a new channel when it detects the channel is deleted but just deleting the ticket would likely be more practical edit: apparently I forgot how githubs reply system works |
- change close function on manager so tickets without channel can be closed - create an event listener to close tickets when someone deletes a channel Note: The ticket will be closed when someone deletes the channel, but it is supposed to be a fallback. Pinned messages will not be stored. Fixes discord-tickets#276
* fix(channels): close ticket when the channel is deleted - change close function on manager so tickets without channel can be closed - create an event listener to close tickets when someone deletes a channel Note: The ticket will be closed when someone deletes the channel, but it is supposed to be a fallback. Pinned messages will not be stored. Fixes discord-tickets#276 * docs: add @n1kkl as a contributor * docs: add FoxXxHater as a contributor for platform (discord-tickets#368) * docs: update CONTRIBUTORS.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * refactor(docker): Rewrite Dockerfile - Image comes in at around 203 MB now * feat(docker): Add compose config * docs: add AdminRAT as a contributor for platform (discord-tickets#370) * docs: update CONTRIBUTORS.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add c43721 as a contributor for platform (discord-tickets#371) * docs: update CONTRIBUTORS.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Isaac <git@eartharoid.me> * docs: add c43721 as a contributor for doc (discord-tickets#373) * docs: update CONTRIBUTORS.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * Update CONTRIBUTORS.md * Update SECURITY.md * docs: update CONTRIBUTORS.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update contributors list * fix: update to`discord.js@13.14.0` * Increase channel delete delay --------- Co-authored-by: Nikkl <niklas@nikkl.me> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: AdminRAT <24538037+AdminRAT@users.noreply.github.com> Co-authored-by: Isaac <git@eartharoid.me>
Describe the bug
If someone manually deletes a ticket's channel, you can not close the ticket associated with that channel. This leaves the user unable to create a new ticket since they can't close their old one.
Additionally, it requires DB writes and a server restart to clear out the the ticket.
To reproduce
Expected behaviour
The ticket is able to be closed despite the state of discord. If a channel or category doesn't exist anymore, the ticket should still close.
Screenshots
Additional Context
The text was updated successfully, but these errors were encountered: