Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth2: clarify redirect_uri needs to be same as auth url #4749

Merged
merged 2 commits into from
Apr 5, 2022
Merged

oauth2: clarify redirect_uri needs to be same as auth url #4749

merged 2 commits into from
Apr 5, 2022

Conversation

splatterxl
Copy link
Contributor

@splatterxl splatterxl commented Apr 3, 2022

This PR rewords the specification of redirect_uri at the code exchange in
the OAuth2 docs to clarify that it is shared between it and the authorization
URL.

@Lulalaby
Copy link
Contributor

Lulalaby commented Apr 4, 2022

I would've said something like "one of your", because you can have multiple urls saved in the dev portal.

@night
Copy link
Member

night commented Apr 4, 2022

This is technically inaccurate. It is the redirect URI associated with an authorization. If the redirect URI is not specified during the authorization request, it uses the first URL registered for the application. In the token exchange, specifying the redirect URI is also optional.

@splatterxl
Copy link
Contributor Author

I would've said something like "one of your", because you can have multiple urls saved in the dev portal.

@Lulalaby I wouldn't put this in because the discussion I referenced shows the redirect_uri has to be a specific one

This is technically inaccurate. It is the redirect URI associated with an authorization. If the redirect URI is not specified during the authorization request, it uses the first URL registered for the application. In the token exchange, specifying the redirect URI is also optional.

@night Thanks, I've updated the wording to reflect this. I didn't go into too much detail with it because part of it is stated in the Authorization URL section.

@night night merged commit 9bcff53 into discord:main Apr 5, 2022
@splatterxl splatterxl deleted the clarify-redirect-uri branch April 8, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants