Add optional parameters to manifestYamlStream in linter (google#732)

discord · Jun 10, 2024 · 3d9a2bf · 3d9a2bf
1 parent 94a40b2
commit 3d9a2bf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/linter/internal/types/stdlib.go b/linter/internal/types/stdlib.go
@@ -124,7 +124,7 @@ func prepareStdlib(g *typeGraph) {
 		"manifestJsonEx":       g.newSimpleFuncType(stringType, "value", "indent"),
 		"manifestJsonMinified": g.newSimpleFuncType(stringType, "value"),
 		"manifestYamlDoc":      g.newFuncType(stringType, []ast.Parameter{required("value"), optional("indent_array_in_object"), optional("quote_keys")}),
-		"manifestYamlStream":   g.newSimpleFuncType(stringType, "value"),
+		"manifestYamlStream":   g.newFuncType(anyArrayType, []ast.Parameter{required("value"), optional("indent_array_in_object"), optional("c_document_end"), optional("quote_keys")}),
 		"manifestXmlJsonml":    g.newSimpleFuncType(stringType, "value"),
 
 		// Arrays
@@ -153,7 +153,7 @@ func prepareStdlib(g *typeGraph) {
 		"minArray":      g.newFuncType(anyArrayType, []ast.Parameter{required("arr"), optional("keyF")}),
 		"maxArray":      g.newFuncType(anyArrayType, []ast.Parameter{required("arr"), optional("keyF")}),
 		"contains":      g.newSimpleFuncType(boolType, "arr", "elem"),
-		"avg":		    	 g.newSimpleFuncType(numberType, "arr"),	
+		"avg":           g.newSimpleFuncType(numberType, "arr"),
 		"all":           g.newSimpleFuncType(boolArrayType, "arr"),
 		"any":           g.newSimpleFuncType(boolArrayType, "arr"),
 		"remove":        g.newSimpleFuncType(anyArrayType, "arr", "elem"),

diff --git a/linter/testdata/stdlib_manifestYamlStream.jsonnet b/linter/testdata/stdlib_manifestYamlStream.jsonnet
@@ -0,0 +1,4 @@
+std.manifestYamlDoc([
+  { foo: "bar" },
+  { baz: "qux" },
+], indent_array_in_object=false, quote_keys=true)
diff --git a/linter/testdata/stdlib_manifestYamlStream.linter.golden b/linter/testdata/stdlib_manifestYamlStream.linter.golden