Fix ScrollView component occasionally producing strange flings #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://app.asana.com/0/1200546912788443/1202237077179474/f and, specifically, the bug reported filed here.
Long story short, the workaround Facebook introduced for a platform bug occasionally results in flings that do not reflect the expected fling direction. My experimental fix here is to only apply this fix on platform versions affected by the bug (IE:
P). We could be a bit more conservative and also apply the workaround onQ/10 and I'd still be happy (my phone's running 12) but I'm not sure that we need to. The bug was marked fixed in March 2019, andQwas released that September, so it should be fine.