Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rules_ios] Re-enable cpp rules #3

Merged
merged 1 commit into from
Apr 25, 2023
Merged

[rules_ios] Re-enable cpp rules #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rules/library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,7 +1018,7 @@ def apple_library(name, library_tools = {}, export_private_headers = True, names
_append_headermap_copts(swift_angle_bracket_hmap_name, "-I", additional_objc_copts, additional_swift_copts, additional_cc_copts)

# Note: this line is intentionally disabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this isn't intentionally disabled anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't remove that line, because it's still there upstream where they've re-enabled cpp as well 😂

https://github.com/bazel-ios/rules_ios/blob/master/rules/library.bzl#L1021

if cpp_sources and False:
if cpp_sources:
additional_cc_copts.append("-I.")
native.objc_library(
name = cpp_libname,
Expand Down