Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add initial support for super reactions #744

Merged
merged 16 commits into from
Feb 23, 2024

Conversation

Mateo-tem
Copy link
Contributor

@Mateo-tem Mateo-tem commented Apr 6, 2023

Please describe the changes this PR makes and why it should be merged:

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 5:12pm

deno/payloads/v10/channel.ts Outdated Show resolved Hide resolved
vladfrangu
vladfrangu previously approved these changes Apr 7, 2023
@vladfrangu
Copy link
Member

thiiiis needs a rebase

@JJRcop

This comment was marked as off-topic.

@Syjalo
Copy link
Contributor

Syjalo commented May 20, 2023

We only add what is documented (or will be documented). Suggest changes in the docs PR.

@JJRcop
Copy link

JJRcop commented May 20, 2023

Ah, I misplaced the repo this was on, thanks.

Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The APIReaction interface is missing the me_burst property, and some of the descriptions are outdated

@Mateo-tem Mateo-tem requested review from a team as code owners August 24, 2023 22:50
deno/rest/v10/channel.ts Outdated Show resolved Hide resolved
@Jiralite
Copy link
Member

Hey @Mateo-tem, are you able to split this pull request up so we have something to merge?

@Mateo-tem
Copy link
Contributor Author

Hey @Mateo-tem, are you able to split this pull request up so we have something to merge?

Yes! I'll do that in a moment 🫡

deno/payloads/v10/channel.ts Outdated Show resolved Hide resolved
deno/payloads/v9/channel.ts Outdated Show resolved Hide resolved
payloads/v10/channel.ts Outdated Show resolved Hide resolved
payloads/v9/channel.ts Outdated Show resolved Hide resolved
deno/payloads/v10/channel.ts Outdated Show resolved Hide resolved
deno/payloads/v9/channel.ts Outdated Show resolved Hide resolved
payloads/v10/channel.ts Outdated Show resolved Hide resolved
payloads/v9/channel.ts Outdated Show resolved Hide resolved
Mateo-tem and others added 2 commits February 22, 2024 11:44
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@almeidx almeidx dismissed stale reviews from vladfrangu and Jiralite February 23, 2024 00:15

Stale

@vladfrangu vladfrangu changed the title feat: add support for super reactions feat: add initial support for super reactions Feb 23, 2024
@vladfrangu vladfrangu merged commit 150dc46 into discordjs:main Feb 23, 2024
6 checks passed
@Mateo-tem Mateo-tem deleted the feat/super-reactions branch February 23, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants