feat(CDN#guildIcon): implement dynamic logic (#53)

discordjs · Sep 7, 2021 · c4b2803 · c4b2803
1 parent 78212bb
commit c4b2803
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/packages/rest/__tests__/CDN.test.ts b/packages/rest/__tests__/CDN.test.ts
@@ -56,6 +56,14 @@ test('icon default', () => {
 	expect(cdn.icon(id, hash)).toBe(`${base}/icons/${id}/${hash}.png`);
 });
 
+test('guildIcon dynamic-animated', () => {
+	expect(cdn.icon(id, animatedHash, { dynamic: true })).toBe(`${base}/icons/${id}/${animatedHash}.gif`);
+});
+
+test('guildIcon dynamic-not-animated', () => {
+	expect(cdn.icon(id, hash, { dynamic: true })).toBe(`${base}/icons/${id}/${hash}.png`);
+});
+
 test('splash default', () => {
 	expect(cdn.splash(id, hash)).toBe(`${base}/splashes/${id}/${hash}.png`);
 });

diff --git a/packages/rest/src/lib/CDN.ts b/packages/rest/src/lib/CDN.ts
@@ -99,8 +99,12 @@ export class CDN {
 	 * @param iconHash The hash provided by Discord for this icon
 	 * @param options Optional options for the icon
 	 */
-	public icon(id: string, iconHash: string, options?: ImageURLOptions): string {
-		return this.makeURL(`/icons/${id}/${iconHash}`, options);
+	public icon(guildId: string, iconHash: string, { dynamic = false, ...options }: ImageURLOptions = {}): string {
+		if (dynamic && iconHash.startsWith('a_')) {
+			options.extension = 'gif';
+		}
+
+		return this.makeURL(`/icons/${guildId}/${iconHash}`, options);
 	}
 
 	/**