"undefined" debug message on successful websocket closure #9594
Labels
Comments
Renegade334
added a commit
to Renegade334/discord.js
that referenced
this issue
Sep 21, 2023
kodiakhq bot
pushed a commit
that referenced
this issue
Oct 21, 2023
…9846) * style: prevent 'undefined' debug message on intentional shard closure addresses #9594 * refactor(WebSocketManager#destroy): improve debug messaging cleaner stacktrace format gracefully closing shards will display an appropriate debug `reason` * style: unresumable debug messaging --------- Co-authored-by: Almeida <almeidx@pm.me>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Which package is this bug report for?
discord.js
Issue description
Very minor issue, but on a successful closure of a shard's websocket (ie. code 1000), the client will emit "undefined" as a debug event:
[WS => Shard 0] undefinedThis happens because at present, in client/websocket/WebSocketManager.js, the close code is only resolved against
discord-api-types/v10::GatewayCloseCodesand not also against@discordjs/ws::CloseCodes.Should ideally be changed to resolve against both.
Code sample
No response
Versions
14.11.0
Issue priority
Low (slightly annoying)
Which partials do you have configured?
Not applicable
Which gateway intents are you subscribing to?
Not applicable
I have tested this issue on a development release
No response
The text was updated successfully, but these errors were encountered: