Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WebsocketManager): retroactive token setting #10418

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

didinele
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
We need this for v15.

@didinele didinele added this to the ws 2.0.0 milestone Jul 31, 2024
@didinele didinele requested a review from a team as a code owner July 31, 2024 07:47
@didinele didinele requested review from vladfrangu and iCrawl July 31, 2024 07:47
Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Jul 31, 2024 11:42am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 11:42am

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 50.83%. Comparing base (785ec8f) to head (825739a).
Report is 1 commits behind head on main.

Files Patch % Lines
packages/ws/src/ws/WebSocketManager.ts 78.78% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10418      +/-   ##
==========================================
+ Coverage   50.77%   50.83%   +0.06%     
==========================================
  Files         228      228              
  Lines       20662    20690      +28     
  Branches     1255     1281      +26     
==========================================
+ Hits        10491    10518      +27     
- Misses      10127    10128       +1     
  Partials       44       44              
Flag Coverage Δ
ws 52.50% <80.00%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit de94eaf into main Jul 31, 2024
8 checks passed
@kodiakhq kodiakhq bot deleted the feat/ws-set-token branch July 31, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants