Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formatters): add guild navigation mentions #9436

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Apr 21, 2023

Please describe the changes this PR makes and why it should be merged:
Upstream:

Status and versioning classification:

@vercel
Copy link

vercel bot commented Apr 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ❌ Failed (Inspect) Aug 25, 2023 0:01am
discord-js-guide ❌ Failed (Inspect) Aug 25, 2023 0:01am

@Jiralite Jiralite added this to the formatters 0.4.0 milestone Apr 21, 2023
Jiralite
Jiralite previously approved these changes Apr 21, 2023
@Jiralite Jiralite dismissed their stale review April 21, 2023 15:20

New upstream changes.

@Syjalo
Copy link
Contributor

Syjalo commented Apr 21, 2023

They can be variables. Or values of an enum, like Faces.

@Jiralite Jiralite self-requested a review April 21, 2023 23:01
@almeidx almeidx changed the title feat: add onboarding screen formatters feat(formatters): add guild navigation mentions Apr 24, 2023
@github-actions
Copy link

github-actions bot commented Aug 24, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 94
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 33

Lighthouse ran on https://discord-js-guide-git-fork-almeidx-formatters-i-79987a-discordjs.vercel.app/

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #9436 (a3a35c3) into main (788888a) will increase coverage by 0.13%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #9436      +/-   ##
==========================================
+ Coverage   59.80%   59.93%   +0.13%     
==========================================
  Files         234      234              
  Lines       15808    15803       -5     
  Branches     1196     1196              
==========================================
+ Hits         9454     9472      +18     
+ Misses       6309     6286      -23     
  Partials       45       45              
Flag Coverage Δ
builders 98.69% <ø> (ø)
formatters 99.39% <100.00%> (+0.01%) ⬆️
next ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
apps/guide/src/app/_global-error.tsx 0.00% <ø> (ø)
apps/guide/src/app/guide/[...slug]/page.tsx 0.00% <ø> (ø)
apps/guide/src/app/guide/layout.tsx 0.00% <ø> (ø)
apps/guide/src/app/layout.tsx 0.00% <ø> (ø)
apps/guide/src/components/Mdx.tsx 0.00% <ø> (ø)
apps/guide/src/components/Nav.tsx 0.00% <ø> (ø)
apps/guide/src/components/Sidebar.tsx 0.00% <ø> (ø)
apps/website/src/app/_global-error.tsx 0.00% <ø> (ø)
...c/app/docs/packages/[package]/[version]/layout.tsx 0.00% <ø> (ø)
...src/app/docs/packages/[package]/[version]/page.tsx 0.00% <ø> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@Jiralite Jiralite removed the blocked label Aug 25, 2023
@Mysterious-Dev
Copy link

Upstream merged 🥳

@kodiakhq kodiakhq bot merged commit 566d5e2 into discordjs:main Aug 25, 2023
4 checks passed
@almeidx almeidx deleted the formatters/id-formatters branch August 25, 2023 12:08
almeidx added a commit to almeidx/discord.js that referenced this pull request Sep 24, 2023
* feat(formatters): add guild navigation mentions

* docs: dont force support article locale

Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>

---------

Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants