Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(SharedNameAndDescription): Fix typo in setNameLocalization() description #9656

Merged
merged 1 commit into from
Jun 17, 2023

Conversation

ShadowAya
Copy link
Contributor

@ShadowAya ShadowAya commented Jun 17, 2023

Please describe the changes this PR makes and why it should be merged:
fixed a JSDoc typo in NameAndDescription.ts > setNameLocalization

Status and versioning classification:
This PR only includes non-code changes, like changes to documentation, README, etc.

fix JSDoc typo in NameAndDescription.ts > setNameLocalization
@ShadowAya ShadowAya requested a review from a team as a code owner June 17, 2023 14:24
@vercel
Copy link

vercel bot commented Jun 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Jun 17, 2023 2:24pm
discord-js-guide ⬜️ Ignored (Inspect) Jun 17, 2023 2:24pm

@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #9656 (1c41716) into main (766be94) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #9656   +/-   ##
=======================================
  Coverage   58.20%   58.20%           
=======================================
  Files         227      227           
  Lines       14902    14902           
  Branches     1131     1131           
=======================================
  Hits         8673     8673           
  Misses       6189     6189           
  Partials       40       40           
Flag Coverage Δ
builders 98.69% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...actions/slashCommands/mixins/NameAndDescription.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 75d91b5 into discordjs:main Jun 17, 2023
@Jiralite Jiralite changed the title setNameLocalization typo docs(SharedNameAndDescription): Fix typo in setNameLocalization() description Jun 17, 2023
@Jiralite Jiralite added this to the builders 1.7.0 milestone Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants