feat(Client): AsyncIterator-returning method for fetching members #9771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-guide-git-fork-almeidx-core-request-2a2622-discordjs.vercel.app/ |
This comment was marked as duplicate.
This comment was marked as duplicate.
jaw0r3k
approved these changes
Aug 15, 2023
kyranet
requested changes
Aug 16, 2023
almeidx
force-pushed
the
core/request-guild-members-iterator
branch
2 times, most recently
from
ed7b955
to
c143250
Compare
kyranet
previously requested changes
Aug 17, 2023
almeidx
force-pushed
the
core/request-guild-members-iterator
branch
from
c143250
to
66e733c
Compare
vladfrangu
previously requested changes
Sep 23, 2023
almeidx
requested review from
a team
and removed request for
a team,
monbrey,
almostSouji,
iCrawl,
SpaceEEC,
didinele,
Jiralite,
suneettipirneni and
ckohen
vladfrangu
approved these changes
Nov 7, 2023
kyranet
approved these changes
Nov 7, 2023
Jiralite
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Resolves #9017
Not sure what to name the new method, open to suggestions
🤖 Generated by Copilot at 15465c6
Summary
✨♻️📚
Added a new way to fetch guild members data using an async iterator. Improved the existing method to use the new iterator. Changed
packages/core/src/client.ts.Walkthrough
requestGuildMembersIteratormethod toClientclass to return an async iterator for guild members data (link, link)requestGuildMembersmethod to userequestGuildMembersIteratorinternally and collect the data into a promise (link)onandclearTimeoutfunctions fromnode:eventsandnode:timersmodules forrequestGuildMembersIterator(link)Status and versioning classification: