ci: fix npm dev release workflow #9817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Jiralite
approved these changes
Sep 1, 2023
jaw0r3k
approved these changes
Sep 1, 2023
vladfrangu
approved these changes
Sep 1, 2023
iCrawl
approved these changes
Sep 2, 2023
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-ci-fix-dev-publish-discordjs.vercel.app/ |
almeidx
pushed a commit
to almeidx/discord.js
that referenced
this pull request
Sep 24, 2023
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
pnpmdoes not allow publishing with an unclean git tree by default, as seen here.I'm not entirely sure why we do the whole
|| truething in the workflow, since it made it not fail despite clearly failing. I assume it's a workaround for cases where we publish a version that's already been published (e.g. due to manual workflow triggers or things of that sort), so I didn't touch it.