Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add guild member #9877

Merged
merged 12 commits into from
Nov 5, 2023
Merged

feat: add guild member #9877

merged 12 commits into from
Nov 5, 2023

Conversation

heyk1n
Copy link
Contributor

@heyk1n heyk1n commented Oct 7, 2023 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
I created an addMember method to the GuildsAPI, because I think someone needs this method

Status and versioning classification:

  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Oct 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2023 6:39pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2023 6:39pm

@github-actions
Copy link

github-actions bot commented Oct 7, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 86
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 92
🟠 PWA 67

Lighthouse ran on https://discord-js-git-fork-k1iin-main-discordjs.vercel.app/

@Jiralite Jiralite added this to the core 1.1.0 milestone Oct 7, 2023
@heyk1n heyk1n marked this pull request as ready for review October 7, 2023 16:06
@heyk1n heyk1n requested a review from a team as a code owner October 7, 2023 16:06
@heyk1n heyk1n deleted the branch discordjs:main October 7, 2023 16:21
@heyk1n heyk1n closed this Oct 7, 2023
@heyk1n heyk1n deleted the main branch October 7, 2023 16:21
@heyk1n heyk1n restored the main branch October 7, 2023 16:22
@heyk1n heyk1n reopened this Oct 7, 2023
@heyk1n @jaw0r3k
Update packages/core/src/api/guild.ts
b63e1c7 
Co-authored-by: Jaw0r3k <jaworekwiadomosci@gmail.com>
@Jiralite
Copy link
Member

Jiralite commented Oct 7, 2023

Should this be in OAuth2API since it's with respect to OAuth2?

@heyk1n
Copy link
Contributor Author

heyk1n commented Oct 7, 2023 •
edited
Loading

Should this be in OAuth2API since it's with respect to OAuth2?

I was also thinking about that earlier, but I noticed that the Routes.guildMember endpoint is part of the Guild (in the dev portal docs), So, I added it to the GuildsAPI. Do I need to move this to the OAuth2API or not?

@jaw0r3k
Copy link
Contributor

jaw0r3k commented Oct 8, 2023 •
edited
Loading

Also change the formatting, as rest of the code uses tabs instead of spaces

@heyk1n @jaw0r3k
add missed semicolon
1d7189d 
Co-authored-by: Jaw0r3k <jaworekwiadomosci@gmail.com>
@kyranet
Copy link
Member

kyranet commented Oct 9, 2023

@k1iin can you run pnpm run lint, please? That'll resolve the issues reported by CI.

@vladfrangu
Copy link
Member

Should this be in OAuth2API since it's with respect to OAuth2?

It's a guild API, so no.

@Jiralite
Copy link
Member

Please resolve conflicts.

Jiralite
Jiralite requested changes Oct 28, 2023
View reviewed changes
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9877 (comment)

@heyk1n
Copy link
Contributor Author

heyk1n commented Oct 28, 2023 •
edited
Loading

@k1iin can you run pnpm run lint, please? That'll resolve the issues reported by CI.

i got this error when running lint

> @discordjs/discord.js@0.0.0 lint /home/runner/discordjs/discord.js
> turbo run lint --concurrency=4

 ELIFECYCLE  Command failed.

@Jiralite
Copy link
Member

That can't be the entire output... can you show it all?

@kodiakhq kodiakhq bot merged commit c051ed9 into discordjs:main Nov 5, 2023
5 checks passed
@heyk1n heyk1n deleted the main branch November 5, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaw0r3k jaw0r3k jaw0r3k left review comments

@suneettipirneni suneettipirneni suneettipirneni approved these changes

@Jiralite Jiralite Jiralite approved these changes

@kyranet kyranet kyranet approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
api support packages:core semver:minor
Projects
discord.js
Archived in project
Milestone
core 1.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@heyk1n @Jiralite @jaw0r3k @kyranet @vladfrangu @suneettipirneni