Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(User): add avatarDecorationData #9888

Merged
merged 6 commits into from
Jun 2, 2024

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Oct 15, 2023

Please describe the changes this PR makes and why it should be merged:
Upstream:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Oct 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 9:21pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 9:21pm

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.21%. Comparing base (35207b0) to head (dbf8c1e).
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9888       +/-   ##
===========================================
- Coverage   95.89%   41.21%   -54.69%     
===========================================
  Files          44       48        +4     
  Lines        3634     8898     +5264     
  Branches      283      267       -16     
===========================================
+ Hits         3485     3667      +182     
- Misses        149     5228     +5079     
- Partials        0        3        +3     
Flag Coverage Δ
brokers 41.21% <100.00%> (-54.69%) ⬇️
builders 41.21% <100.00%> (-54.69%) ⬇️
collection 41.21% <100.00%> (-54.69%) ⬇️
discord.js 41.21% <100.00%> (-54.69%) ⬇️
formatters 41.21% <100.00%> (-54.69%) ⬇️
guide 41.21% <100.00%> (-54.69%) ⬇️
next 41.21% <100.00%> (-54.69%) ⬇️
proxy 41.21% <100.00%> (-54.69%) ⬇️
rest 41.21% <100.00%> (-54.69%) ⬇️
util 41.21% <100.00%> (-54.69%) ⬇️
utilities 41.21% <100.00%> (-54.69%) ⬇️
voice 41.21% <100.00%> (-54.69%) ⬇️
website 41.21% <100.00%> (-54.69%) ⬇️
ws 41.21% <100.00%> (-54.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@almeidx almeidx force-pushed the discord.js/avatar-decoration-presets branch from 90c1fc3 to 88e85b6 Compare October 15, 2023 19:19
@github-actions
Copy link

github-actions bot commented Oct 15, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 68
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 33

Lighthouse ran on https://discord-js-guide-git-discordjs-avatar-decorati-739fa9-discordjs.vercel.app/

@Jiralite Jiralite removed this from the discord.js 14.15 milestone Oct 19, 2023
@almeidx almeidx force-pushed the discord.js/avatar-decoration-presets branch from 79bbcd1 to 1e1c732 Compare October 22, 2023 15:31
@almeidx almeidx force-pushed the discord.js/avatar-decoration-presets branch from 1e1c732 to a4417d7 Compare November 2, 2023 01:40
@Jiralite
Copy link
Member

In discord.js, should this be checked for in equals()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

User#avatarDecoration property is always null.
7 participants