Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use descriptive type parameter names #9937

Merged
merged 3 commits into from
Nov 12, 2023

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Nov 10, 2023

Please describe the changes this PR makes and why it should be merged:

🤖 Generated by Copilot at 75ff168

This pull request renames generic type parameters in various TypeScript files to improve readability and clarity of the code. It also adds a new ESLint rule for type parameter naming conventions and updates the linting scripts and configuration accordingly. The changes affect the ItemLink, resolveMembers, Broker, RPCRedis, ActionRowBuilder, ApplicationCommandOptionWithChoicesAndAutocompleteMixin, normalizeArray, Collection, Client, and Assertions classes and functions, as well as the typings folder and the docgen package.

Status and versioning classification:

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2023 5:21pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2023 5:21pm

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #9937 (d3dc16d) into main (4ff3ea4) will increase coverage by 0.21%.
The diff coverage is 96.67%.

@@            Coverage Diff             @@
##             main    #9937      +/-   ##
==========================================
+ Coverage   59.14%   59.35%   +0.21%     
==========================================
  Files         237      237              
  Lines       16746    16840      +94     
  Branches     1238     1237       -1     
==========================================
+ Hits         9904     9995      +91     
- Misses       6797     6800       +3     
  Partials       45       45              
Flag Coverage Δ
brokers 63.49% <58.33%> (+0.32%) ⬆️
builders 95.53% <100.00%> (+<0.01%) ⬆️
collection 99.32% <100.00%> (+0.03%) ⬆️
formatters 99.47% <100.00%> (+0.01%) ⬆️
guide 0.00% <ø> (ø)
next ∅ <ø> (∅)
proxy 75.00% <ø> (ø)
rest 92.82% <100.00%> (ø)
util 70.70% <100.00%> (ø)
utilities 100.00% <ø> (ø)
voice 63.64% <83.33%> (ø)
website 0.00% <0.00%> (ø)
ws 52.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/brokers/src/brokers/Broker.ts 96.73% <100.00%> (+0.14%) ⬆️
packages/brokers/src/brokers/redis/PubSubRedis.ts 84.48% <100.00%> (ø)
packages/builders/src/components/ActionRow.ts 100.00% <100.00%> (ø)
packages/builders/src/components/Components.ts 92.30% <100.00%> (+0.15%) ⬆️
...lders/src/interactions/slashCommands/Assertions.ts 98.00% <100.00%> (ø)
...ionCommandOptionWithChoicesAndAutocompleteMixin.ts 100.00% <100.00%> (ø)
.../slashCommands/mixins/SharedSlashCommandOptions.ts 100.00% <100.00%> (ø)
packages/builders/src/util/normalizeArray.ts 100.00% <100.00%> (ø)
packages/collection/src/collection.ts 99.32% <100.00%> (+0.03%) ⬆️
packages/formatters/src/formatters.ts 100.00% <100.00%> (ø)
... and 12 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

packages/builders/src/components/Components.ts Outdated Show resolved Hide resolved
packages/builders/src/components/Components.ts Outdated Show resolved Hide resolved
packages/util/src/types.ts Outdated Show resolved Hide resolved
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 975d5f1 into main Nov 12, 2023
21 checks passed
@kodiakhq kodiakhq bot deleted the chore/descriptive-type-parameter-names branch November 12, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants