-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use descriptive type parameter names #9937
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almeidx
requested review from
vladfrangu,
kyranet,
SpaceEEC,
didinele,
Jiralite,
suneettipirneni and
ckohen
November 10, 2023 19:50
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #9937 +/- ##
==========================================
+ Coverage 59.14% 59.35% +0.21%
==========================================
Files 237 237
Lines 16746 16840 +94
Branches 1238 1237 -1
==========================================
+ Hits 9904 9995 +91
- Misses 6797 6800 +3
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
vladfrangu
approved these changes
Nov 10, 2023
Jiralite
approved these changes
Nov 10, 2023
suneettipirneni
approved these changes
Nov 10, 2023
ckohen
reviewed
Nov 11, 2023
didinele
approved these changes
Nov 11, 2023
kyranet
previously requested changes
Nov 11, 2023
kyranet
approved these changes
Nov 11, 2023
iCrawl
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
🤖 Generated by Copilot at 75ff168
This pull request renames generic type parameters in various TypeScript files to improve readability and clarity of the code. It also adds a new ESLint rule for type parameter naming conventions and updates the linting scripts and configuration accordingly. The changes affect the
ItemLink
,resolveMembers
,Broker
,RPCRedis
,ActionRowBuilder
,ApplicationCommandOptionWithChoicesAndAutocompleteMixin
,normalizeArray
,Collection
,Client
, andAssertions
classes and functions, as well as thetypings
folder and thedocgen
package.Status and versioning classification: