Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: A general code clean-up #49

Merged
merged 2 commits into from
Sep 10, 2024
Merged

DEV: A general code clean-up #49

merged 2 commits into from
Sep 10, 2024

Conversation

CvX
Copy link
Contributor

@CvX CvX commented Sep 10, 2024

Summary:

  • removed computed usage from a glimmer component
  • converted the component to gjs
  • converted the connector to gjs and made it into a regular glimmer component (w/ service injections and a getter instead of setupComponent)
  • used session service injection instead of Session singleton wherever possible
  • moved prop initialization out of a constructor
  • removed a use of string-based action
  • simplified showInSidebar logic
  • converted the initializer to the new class-based paradigm (w/ service injections)
  • added an escape hatch (isDestroying/isDestroyed check) to a later call
  • add a matching removeEventListener to window.matchMedia(…).addEventListener
  • used qunit-dom in tests

@CvX CvX merged commit 07e5e51 into main Sep 10, 2024
4 checks passed
@CvX CvX deleted the clean branch September 10, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants