FEATURE: add --tags and --skip-tags options #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow config manifests to be tagged, so a pups run can apply a subset of run commands. Lots of linting. Fixing test imports, update MiniTest::Test -> Minitest::Test
|
linting ... and ruby update ... can you take that as well? |
|
Linted the rest of the files, added a lint ignore rule for the existing Eval, and updated referenced github task rubies to 3.2. |
SamSaffron
reviewed
Oct 23, 2023
lib/pups/config.rb
Outdated
| @config = config | ||
|
|
||
| # remove any ignored config elements prior to any more processing | ||
| ignored&.each { |e| @config.delete(e) } | ||
|
|
||
| filter_tags(tags) | ||
| filter_tags(skip_tags, true) |
There was a problem hiding this comment.
sig on this method is a bit odd:
Maybe ...
filter_tags(include_tags: ... , exclude_tags: ... )
There was a problem hiding this comment.
Updated, it's a bit more verbose now but hopefully a little more readable
SamSaffron
approved these changes
Oct 23, 2023
|
we should publish a gem here as well after you include this, maybe also update the readme? |
|
Yeah I can take care of readme+changelog too 👍 |
use include_tags, exclude_tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow config manifests to be tagged, so a pups run can apply a subset of run commands.
--tags runs only commands tagged with listed tags.
--skip-tags runs commands not tagged with listed tags.
Lots of linting.
Fixing test imports, update MiniTest::Test -> Minitest::Test