Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default values to select menus #315

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Add default values to select menus #315

merged 5 commits into from
Sep 27, 2023

Conversation

sebm253
Copy link
Member

@sebm253 sebm253 commented Sep 20, 2023

@sebm253 sebm253 marked this pull request as ready for review September 22, 2023 20:29
@sebm253 sebm253 requested a review from topi314 September 22, 2023 20:31
topi314
topi314 reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@topi314 topi314 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about convenient functions?

NewSelectMenuDefaultUser(id)
NewSelectMenuDefaultRole(id)
NewSelectMenuDefaultChannel(id)

nvm

@sebm253 sebm253 requested a review from topi314 September 27, 2023 13:58
@sebm253 sebm253 merged commit c9986e8 into master Sep 27, 2023
3 checks passed
@sebm253 sebm253 deleted the patch/default-values-selects branch September 27, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topi314 topi314 topi314 approved these changes

Assignees
No one assigned
Labels
type:enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebm253 @topi314