Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: imports -> sources #1518

Merged
merged 5 commits into from
May 15, 2024
Merged

LSP: imports -> sources #1518

merged 5 commits into from
May 15, 2024

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented May 13, 2024 •
edited
Loading

Closes #1459.

PR Checklist (not all items are relevant to all PRs)

  • ❌ Added unit-tests (for runtime code)
  • ❌ Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • ❌ Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • ❌ Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • ❌ Updated dynamic module to match generated-code behaviour
  • ❌ Added documentation
  • Updated changelog

@kubukoz kubukoz marked this pull request as ready for review May 13, 2024 16:56
@Baccata Baccata merged commit d35d82b into series/0.18 May 15, 2024
11 checks passed
@Baccata Baccata deleted the lsp-imports-sources branch May 15, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baccata Baccata Baccata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LSP codegen: should probably use sources instead of imports
2 participants
@kubukoz @Baccata