Allows resource startup timeout to be configured #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mcgizzle
force-pushed
the
issue-489/configurable-startup-timeout
branch
from
46ad081 to
b0f0894
Compare
Configurable by a new system property
mcgizzle
force-pushed
the
issue-489/configurable-startup-timeout
branch
from
b0f0894 to
a2ec5cc
Compare
Baccata
reviewed
Feb 25, 2022
| @@ -119,9 +120,15 @@ trait RunnerCompat[F[_]] { self: sbt.testing.Runner => | |||
| gate) | |||
| stillRunning.set(sbtTasks.size) | |||
|
|
|||
| val maybeTimeout: Option[FiniteDuration] = Try(System.getProperty("weaver.test.startupTimeout")) | |||
There was a problem hiding this comment.
pro-tip : you can use sys.props (which gives you a scala map of the available system properties)
mcgizzle
force-pushed
the
issue-489/configurable-startup-timeout
branch
from
fc6d638 to
ff06057
Compare
|
@mcgizzle can you run |
|
Merging, will fmt myself :) |
|
Thanks :) I'm on leave this week and don't have my laptop with me, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configurable by a new system property
For test setups that do a lot of work, 120 seconds can be too short.
Open to suggestions for the name and how to handle the
IllegalArgumentExceptionif the key is empty.