DisciplineFSuite: fix race condition #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
its working in my project. i should have test it after changing TrieMap to synchronized, before this PR the code was throwing NoSuchElementException, now after changes it is working (run many times) |
Baccata
approved these changes
Jul 29, 2022
|
We're having issues with sonatype, I won't release this patch straight away as I need time to investigate a little |
|
any updates? |
|
Thanks for reminding me. Looks like 0.6.14 has successfully made its way to central though the CI was failing. Probably a red-herring of some sort. Absent any other information, I've triggered 0.6.15 : https://github.com/disneystreaming/weaver-test/releases/tag/v0.6.15, we'll see how it goes. |
|
I had to re-trigger the job cause it failed and I had missed the notif. Anyway, it's definitely here now :
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use constant monitors when using synchronized
quick followup of #548
(friday, friday, friday)