Use builder pattern for CheckConfig #633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it is acceptable to have a compile-time only dependency could use https://github.com/alexarchambault/data-class. Actually, no need to add a dependency, I could inline the macro expansion for |
|
Hi ! What's the status of this PR ? I'm experiencing the same issues when dealing with seeds atm |
Because this PR is binary breaking, I am not sure if/when it will be merged 🤷 |
|
Resolved by typelevel/weaver-test#39. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
CheckConfigusing the builder pattern (tweaked the output of https://github.com/alexarchambault/data-class).Why
org.scalacheck.rng.Seedinstead ofLong#632.