refresh current page after toggle/run job is used #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO, this allows a much nicer UX.
if I'm looking at show page of a job and click
run, most of the time I'd like to continue in that page.If I do want to go back to jobs list, it's just one click after the refresh. With the current redirect, the opposite use case does not take one single click but instead typing job name again (assuming decent list of jobs) and opening it.
Not sure about the toggle button, but I guess it'd make sense to do the same.
For the edit button it'd be great to do the same but I've been unable to properly get job id into a
redirectforJobEdit/EditForm