-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple brokers in kafka executor #1037
Allow multiple brokers in kafka executor #1037
Conversation
2690b08
to
acfcfb3
Compare
@vcastellm can you take look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! I have a couple of questions, though.
acfcfb3
to
cd9417a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This are failing tough |
I'm checking the CI |
Let me know if there is anything I can help |
SSL tests certs updated, rebase with master and it should work @Espina2 |
Signed-off-by: Paulo Moura <itsme@paulomoura.com.pt>
cd9417a
to
bfb8004
Compare
@vcastellm done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kafka is supposed to be distributed, passing only broker can make messages fail if for some reason the broker is not up. In order to circumvent that issue, we can use multiple brokers. This can also improve the publishing rate.
Signed-off-by: Paulo Moura itsme@paulomoura.com.pt