Handle ip changes #1446
Merged
Handle ip changes #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks your this contribution, really appreciated, can you add a simple test file to cover Also, can you switch base branch to https://github.com/distribworks/dkron/tree/4.x branch instead? we'll focus on that at this point. |
…ent from server node IP on raft layer
ivan-kripakov-m10
force-pushed
the
handle_ip_changes
branch
from
991574f
to
986ef63
Compare
|
yes, sure |
ivan-kripakov-m10
force-pushed
the
handle_ip_changes
branch
from
f9c445b
to
98be95b
Compare
…in server_lookup.go)
ivan-kripakov-m10
force-pushed
the
handle_ip_changes
branch
from
98be95b
to
2d3e3d9
Compare
|
@vcastellm how is this PR looking? I'm trying to get a sense of when this might get merged and also a rough idea of when 4.x is coming. |
First v4 beta in the following hours |
vcastellm
added a commit
that referenced
this pull request
Oct 6, 2024
* Convert shell plugin to internal plugin (#975) The purpose of this PR is to embed the shell plugin in the main dkron binary, that will facilitate creating a single binary with the most important executor, for easy deployment using a single binary. * Remove old UI (#984) * Release a light image tag (#988) Omit all plugins except the shell plugin that will be included in the main binary. * Upgrade react admin to v4 (#1436) * Use exponential backoff for retries (#1433) * Handle ip changes (#1446) * consul like approach: add server_lookup to make dkron independent from server node IP on raft layer * handle memberupdate event * query other servers before start & add test * don't remove itself if node is a raft leader * don't remove dkron server node if id matches * Move config init to agent command (#1465) Config init was being done on the root level command but only the agent command was using config values. Now config init is done as pre-run of agent command only, getting rid of extra messages in other commands when the config was missing. * Fix disabled (#1467) * Embed http plugin (#1471) http plugin is one of the most used plugins together with the shell plugin, embedding it in the main binary allow for more lean deployment. * Show all Job fields * Refactor buttons for admin v4 * Docs v4 (#1473) * Reuse http clients with the same configuration (#1474) * Update OpenAPI spec to v3.1.0 and add ACLs spec * Refactor location of types as they not only belong to plugins, but used in general. (#1485) Also add Pro protobuf and gen code as this should be public. * Generate client * Extend protobuf defs for ACLs * Token fields * Minor improvement in RabbitMQ executor (#1500) * nice and forkable goreleaser (#1584) * add support for hash scheduling (#1260) * feat: Login form and admin update (#1589) Upgrade react-admin to v5 Implements a login form to use in Pro version --------- Co-authored-by: Victor Castell <victor@victorcastell.com> Co-authored-by: Ivan Kripakov <108407979+ivan-kripakov-m10@users.noreply.github.com> Co-authored-by: Filipe Pina <636320+fopina@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request is associated with issue #1442
I made several things here:
Query each of the servers and make sure they report no Raft peers.(I'm not sure if it is correct approach)I built image and tested it in k8s using this helm - distribworks/dkron-helm#7
Seems like everything works fine now