busyhandler execution sorting #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
probably member list (in the dashboard page) could use a sort as well ? |
It already does but in the UI https://github.com/distribworks/dkron/blob/master/templates/index.html.tmpl#L25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, busyHandler does no sorting, and the web UI doesn't either.
The result is a page where it is hard to follow any output as executions keep switching order:
Sorting can be done both in the UI or in the busyHandler method.
In the UI it probably saves that (small yet existing) processing from dkron server, but then it shouldn't return an array.
As an API consumer I expect a JSON array response to have some sort of order (usually, from a DB, it would be the cheapest order, the insertion order).
Regardless of the sorting criteria, the same request with the same set of results should always have the same order.
So I'd say it could make sense to leave the UI to order the response but turn it into a mapping/hash (
execution_name: execution) or simply sort inbusyHandlerwith some common criteria such asjobNameorstartTime.I chose the latter in this PR, let me know if you'd rather have another approach.
End result: