Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCP PubSub executor #943

Merged
merged 5 commits into from
May 13, 2021

Conversation

moshebe
Copy link
Contributor

@moshebe moshebe commented Apr 22, 2021

No description provided.

Copy link

@kostyay kostyay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments
LGTM

builtin/bins/dkron-executor-gcppubsub/gcppubsub.go Outdated Show resolved Hide resolved
builtin/bins/dkron-executor-gcppubsub/gcppubsub.go Outdated Show resolved Hide resolved
builtin/bins/dkron-executor-gcppubsub/gcppubsub.go Outdated Show resolved Hide resolved
Copy link
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the nitpicks, thanks for the good work!

builtin/bins/dkron-executor-gcppubsub/gcppubsub.go Outdated Show resolved Hide resolved
Co-authored-by: Victor Castell <victor@victorcastell.com>
@moshebe
Copy link
Contributor Author

moshebe commented May 13, 2021

Fixed.
Thank you @Victorcoder !

@vcastellm vcastellm merged commit 7652293 into distribworks:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants