Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shell executor crashing on missing command #948

Merged
merged 1 commit into from
May 6, 2021
Merged

Fix shell executor crashing on missing command #948

merged 1 commit into from
May 6, 2021

Conversation

yvanoers
Copy link
Collaborator

Fixes #945

vcastellm
vcastellm approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx!

@vcastellm vcastellm merged commit 162e8db into distribworks:master May 6, 2021
@yvanoers yvanoers deleted the fix-shell-crash-empty-config branch May 21, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcastellm vcastellm vcastellm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty Executor Config will cause invalid memory address or nil pointer dereference in SHELL Executor
2 participants
@yvanoers @vcastellm