Fix race conditions #967
Merged
Fix race conditions #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add workaround for package level variables in gin framework - Add mutext around Scheduler.started to prevent concurrent modifications These changes allow the tests to be run with the -race flag and not return any warnings about race conditions.
|
This test seems to intermittently fail now for me which makes me believe that it is a result of these changes, but it is not very clear as to why. I'll dig in further as I have time. |
|
close/reopen to trigger CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow the tests to be run with the -race flag and not return any warnings about race conditions.
Fixes #951