Convert shell plugin to internal plugin

cmd/plugins.go

@@ -64,33 +64,37 @@ func (p *Plugins) DiscoverPlugins() error {
 	}
 
 	for _, file := range processors {
-
 		pluginName, ok := getPluginName(file)
 		if !ok {
 			continue
 		}
 
-		raw, err := p.pluginFactory(file, dkplugin.ProcessorPluginName)
+		raw, err := p.pluginFactory(file, []string{}, dkplugin.ProcessorPluginName)
 		if err != nil {
 			return err
 		}
 		p.Processors[pluginName] = raw.(dkplugin.Processor)
 	}
 
 	for _, file := range executors {
-
 		pluginName, ok := getPluginName(file)
 		if !ok {
 			continue
 		}
 
-		raw, err := p.pluginFactory(file, dkplugin.ExecutorPluginName)
+		raw, err := p.pluginFactory(file, []string{}, dkplugin.ExecutorPluginName)
 		if err != nil {
 			return err
 		}
 		p.Executors[pluginName] = raw.(dkplugin.Executor)
 	}
 
+	raw, err := p.pluginFactory(exePath, []string{"shell"}, dkplugin.ExecutorPluginName)
+	if err != nil {
+		return err
+	}
+	p.Executors["shell"] = raw.(dkplugin.Executor)
+
 	return nil
 }
 
@@ -107,10 +111,10 @@ func getPluginName(file string) (string, bool) {
 	return name, true
 }
 
-func (p *Plugins) pluginFactory(path string, pluginType string) (interface{}, error) {
+func (p *Plugins) pluginFactory(path string, args []string, pluginType string) (interface{}, error) {
 	// Build the plugin client configuration and init the plugin
 	var config plugin.ClientConfig
-	config.Cmd = exec.Command(path)
+	config.Cmd = exec.Command(path, args...)
 	config.HandshakeConfig = dkplugin.Handshake
 	config.Managed = true
 	config.Plugins = dkplugin.PluginMap

cmd/shell.go

@@ -0,0 +1,27 @@
+package cmd
+
+import (
+	dkplugin "github.com/distribworks/dkron/v3/plugin"
+	"github.com/distribworks/dkron/v3/plugin/shell"
+	"github.com/hashicorp/go-plugin"
+	"github.com/spf13/cobra"
+)
+
+var shellCmd = &cobra.Command{
+	Hidden: true,
+	Run: func(cmd *cobra.Command, args []string) {
+		plugin.Serve(&plugin.ServeConfig{
+			HandshakeConfig: dkplugin.Handshake,
+			Plugins: map[string]plugin.Plugin{
+				"executor": &dkplugin.ExecutorPlugin{Executor: &shell.Shell{}},
+			},
+
+			// A non-nil value here enables gRPC serving for this plugin...
+			GRPCServer: plugin.DefaultGRPCServer,
+		})
+	},
+}
+
+func init() {
+	dkronCmd.AddCommand(shellCmd)
+}

builtin/bins/dkron-executor-shell/shell.go → plugin/shell/shell.go

@@ -1,4 +1,4 @@
-package main
+package shell
 
 import (
 	"encoding/base64"

builtin/bins/dkron-executor-shell/shell_test.go → plugin/shell/shell_test.go

@@ -1,4 +1,4 @@
-package main
+package shell
 
 import (
 	"os"

builtin/bins/dkron-executor-shell/shell_unix.go → plugin/shell/shell_unix.go

@@ -1,6 +1,6 @@
 // +build !windows
 
-package main
+package shell
 
 import (
 	"os/exec"

builtin/bins/dkron-executor-shell/shell_windows.go → plugin/shell/shell_windows.go

@@ -1,6 +1,6 @@
 // +build windows
 
-package main
+package shell
 
 import (
 	"os/exec"