Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swagger assets from cdn #997

Merged
merged 1 commit into from
Jun 29, 2021
Merged

swagger assets from cdn #997

merged 1 commit into from
Jun 29, 2021

Conversation

FedeBev
Copy link
Contributor

@FedeBev FedeBev commented Jun 24, 2021

Get (updated) Swagger assets from CDN, this way we don't have to keep them updated anymore and the repo is a bit lighter.

Hope this is welcome

Thanks

@vcastellm
Copy link
Member

vcastellm commented Jun 29, 2021

Thanks for the contribution @FedeBev but the enterprise users won't be happy with this, some of them use proxied networking environments, and doesn't allow internet connections from internal applications, I prefer to have a bit heavier package than force them to allow this connection from their proxy config.

--- EDIT

I just realized that this only affects the docs site 🤐 so, my comment doesn't apply in this case!

@vcastellm vcastellm closed this Jun 29, 2021
@vcastellm vcastellm reopened this Jun 29, 2021
Copy link
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FedeBev
Copy link
Contributor Author

FedeBev commented Jun 29, 2021

Thanks for the contribution @FedeBev but the enterprise users won't be happy with this, some of them use proxied networking environments, and doesn't allow internet connections from internal applications, I prefer to have a bit heavier package than force them to allow this connection from their proxy config.

Are u sure about that? This just affects the public website (or so i thought)

EDIT

--- EDIT

I just realized that this only affects the docs site 🤐 so, my comment doesn't apply in this case!

indeed 😄

@vcastellm vcastellm merged commit bf6828d into distribworks:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants