Remove mocks from .gitignore and generate them for required module. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aving mocks go: finding module for package github.com/ditointernet/go-dito/jwks/mocks go: finding module for package github.com/ditointernet/go-dito/http/mocks github.com/ditointernet/new-segments-service/cmd/rest_api imports github.com/ditointernet/go-dito/http/middleware/authentication tested by github.com/ditointernet/go-dito/http/middleware/authentication.test imports github.com/ditointernet/go-dito/http/mocks: module github.com/ditointernet/go-dito/http@latest found (v1.1.0), but does not contain package github.com/ditointernet/go-dito/http/mocks github.com/ditointernet/new-segments-service/cmd/rest_api imports github.com/ditointernet/go-dito/jwks tested by github.com/ditointernet/go-dito/jwks.test imports github.com/ditointernet/go-dito/jwks/mocks: module github.com/ditointernet/go-dito/jwks@latest found (v1.0.0), but does not contain package github.com/ditointernet/go-dito/jwks/mocks
Mismatch happened at interfac http.AuthorizatorClient ExecuteQuery method's return value and opa.AuthorizationResult type
lucafmarques
added
help wanted
yantoledo
reviewed
Sep 21, 2022
YanToledoDito
approved these changes
Jan 27, 2023
|
🎉 This PR is included in version http-v1.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version jwks-v1.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version log-v1.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version opa-v1.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version trace-v1.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version http-v1.2.0-beta.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving from
go-dito/lib/<module>togo-dito/<module>and runninggo mod tidyon the projectnew-segments-service, Go accuses some modules of not having a required and importedmockspackage. E.g.:To fix this, said modules need to provide the required package as well, because said error blocks users from even maintaining the program that requires them, as Go cannot run/build the program without first validating modules present in go.mod.