Fix type alias substitution #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmackie
commented
Jan 3, 2023
| @@ -121,6 +121,11 @@ impl Substitution { | |||
| for t in tail { | |||
| arguments.push(self.apply_rec(t.clone(), depth)); | |||
| } | |||
| let alias_variables = alias_variables | |||
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 84.40% 84.43% +0.02%
==========================================
Files 83 83
Lines 15274 15296 +22
==========================================
+ Hits 12892 12915 +23
+ Misses 2382 2381 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
added 4 commits
January 3, 2023 19:46
This reverts commit 11ed58d. It doesn't seem to work?
jmackie
force-pushed
the
fix-type-alias-checking
branch
from
76f8ad3
to
45b4c25
Compare
jmackie
commented
Jan 3, 2023
| let builder = std::thread::Builder::new(); | ||
|
|
||
| let handler = builder | ||
| .stack_size( |
There was a problem hiding this comment.
Need to increase the stack size for tests to pass on windows 😬
Hopefully this is just a debug build problem...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (I think) is the correct fix for the bug described in #115.
Note that I'm still swapping out
HashSetforIndexSetbecause we need the determinism for tests.