-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rust crate tokio to 1.25 [SECURITY] #166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate
bot
changed the title
Update Rust crate tokio to 1.23 [SECURITY]
Update Rust crate tokio to 1.24 [SECURITY]
Jan 7, 2023
renovate
bot
force-pushed
the
renovate/crate-tokio-vulnerability
branch
2 times, most recently
from
January 7, 2023 17:39
f73d4a8
to
d3f8db9
Compare
renovate
bot
changed the title
Update Rust crate tokio to 1.24 [SECURITY]
Update Rust crate tokio to 1.23 [SECURITY]
Jan 7, 2023
renovate
bot
force-pushed
the
renovate/crate-tokio-vulnerability
branch
from
January 9, 2023 01:02
d3f8db9
to
f1b84d9
Compare
renovate
bot
changed the title
Update Rust crate tokio to 1.23 [SECURITY]
Update Rust crate tokio to 1.24 [SECURITY]
Jan 9, 2023
renovate
bot
force-pushed
the
renovate/crate-tokio-vulnerability
branch
from
January 9, 2023 07:02
f1b84d9
to
e88c29d
Compare
renovate
bot
changed the title
Update Rust crate tokio to 1.24 [SECURITY]
Update Rust crate tokio to 1.23 [SECURITY]
Jan 9, 2023
renovate
bot
changed the title
Update Rust crate tokio to 1.23 [SECURITY]
Update Rust crate tokio to 1.23 [SECURITY] - autoclosed
Jan 13, 2023
renovate
bot
changed the title
Update Rust crate tokio to 1.23 [SECURITY] - autoclosed
Update Rust crate tokio to 1.23 [SECURITY]
Jan 13, 2023
renovate
bot
force-pushed
the
renovate/crate-tokio-vulnerability
branch
from
January 17, 2023 16:39
e88c29d
to
d478021
Compare
renovate
bot
changed the title
Update Rust crate tokio to 1.23 [SECURITY]
Update Rust crate tokio to 1.24 [SECURITY]
Jan 17, 2023
renovate
bot
force-pushed
the
renovate/crate-tokio-vulnerability
branch
2 times, most recently
from
January 18, 2023 12:17
8e8e297
to
c1d45ce
Compare
renovate
bot
changed the title
Update Rust crate tokio to 1.24 [SECURITY]
Update Rust crate tokio to 1.23 [SECURITY]
Jan 18, 2023
renovate
bot
force-pushed
the
renovate/crate-tokio-vulnerability
branch
from
January 19, 2023 23:42
c1d45ce
to
7bbf0df
Compare
renovate
bot
changed the title
Update Rust crate tokio to 1.23 [SECURITY]
Update Rust crate tokio to 1.24 [SECURITY]
Jan 19, 2023
renovate
bot
changed the title
Update Rust crate tokio to 1.24 [SECURITY]
Update Rust crate tokio to 1.23 [SECURITY]
Jan 20, 2023
renovate
bot
force-pushed
the
renovate/crate-tokio-vulnerability
branch
from
January 23, 2023 12:21
557c877
to
fd21d91
Compare
renovate
bot
changed the title
Update Rust crate tokio to 1.23 [SECURITY]
Update Rust crate tokio to 1.24 [SECURITY]
Jan 23, 2023
renovate
bot
changed the title
Update Rust crate tokio to 1.24 [SECURITY]
Update Rust crate tokio to 1.23 [SECURITY]
Jan 23, 2023
renovate
bot
force-pushed
the
renovate/crate-tokio-vulnerability
branch
from
January 24, 2023 06:37
205dcb2
to
daa9c3d
Compare
renovate
bot
changed the title
Update Rust crate tokio to 1.23 [SECURITY]
Update Rust crate tokio to 1.24 [SECURITY]
Jan 24, 2023
renovate
bot
force-pushed
the
renovate/crate-tokio-vulnerability
branch
from
January 24, 2023 10:34
daa9c3d
to
138de65
Compare
renovate
bot
changed the title
Update Rust crate tokio to 1.24 [SECURITY]
Update Rust crate tokio to 1.23 [SECURITY]
Jan 24, 2023
renovate
bot
force-pushed
the
renovate/crate-tokio-vulnerability
branch
from
February 1, 2023 20:14
138de65
to
959f3ae
Compare
renovate
bot
changed the title
Update Rust crate tokio to 1.23 [SECURITY]
Update Rust crate tokio to 1.25 [SECURITY]
Feb 1, 2023
renovate
bot
changed the title
Update Rust crate tokio to 1.25 [SECURITY]
Update Rust crate tokio to 1.23 [SECURITY]
Feb 2, 2023
renovate
bot
changed the title
Update Rust crate tokio to 1.23 [SECURITY]
Update Rust crate tokio to 1.23 [SECURITY] - autoclosed
Feb 2, 2023
renovate
bot
changed the title
Update Rust crate tokio to 1.23 [SECURITY] - autoclosed
Update Rust crate tokio to 1.23 [SECURITY]
Feb 2, 2023
renovate
bot
force-pushed
the
renovate/crate-tokio-vulnerability
branch
2 times, most recently
from
February 4, 2023 03:35
91b3c93
to
6d6f65a
Compare
renovate
bot
changed the title
Update Rust crate tokio to 1.23 [SECURITY]
Update Rust crate tokio to 1.24 [SECURITY]
Feb 4, 2023
renovate
bot
force-pushed
the
renovate/crate-tokio-vulnerability
branch
from
February 4, 2023 13:45
6d6f65a
to
161c342
Compare
renovate
bot
changed the title
Update Rust crate tokio to 1.24 [SECURITY]
Update Rust crate tokio to 1.25 [SECURITY]
Feb 4, 2023
renovate
bot
force-pushed
the
renovate/crate-tokio-vulnerability
branch
from
February 4, 2023 17:26
161c342
to
678a7c7
Compare
renovate
bot
changed the title
Update Rust crate tokio to 1.25 [SECURITY]
Update Rust crate tokio to 1.24 [SECURITY]
Feb 4, 2023
renovate
bot
force-pushed
the
renovate/crate-tokio-vulnerability
branch
from
February 11, 2023 15:00
678a7c7
to
2130156
Compare
renovate
bot
changed the title
Update Rust crate tokio to 1.24 [SECURITY]
Update Rust crate tokio to 1.25 [SECURITY]
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.22
->1.25
GitHub Vulnerability Alerts
CVE-2023-22466
Impact
When configuring a Windows named pipe server, setting
pipe_mode
will resetreject_remote_clients
tofalse
. If the application has previously configuredreject_remote_clients
totrue
, this effectively undoes the configuration. This also applies ifreject_remote_clients
is not explicitly set as this is the default configuration and is cleared by callingpipe_mode
.Remote clients may only access the named pipe if the named pipe's associated path is accessible via a publically shared folder (SMB).
Patches
The following versions have been patched:
The fix will also be present in all releases starting from version 1.24.0.
Named pipes were introduced to Tokio in version 1.7.0, so releases older than 1.7.0 are not affected.
Workarounds
Ensure that
pipe_mode
is set first after initializing aServerOptions
. For example:References
https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-createnamedpipea#pipe_reject_remote_clients
GHSA-4q83-7cq4-p6wg
tokio::io::ReadHalf<T>::unsplit
can violate thePin
contractThe soundness issue is described in the tokio/issues#5372
Specific set of conditions needed to trigger an issue (a !Unpin type in ReadHalf)
is unusual, combined with the difficulty of making any arbitrary use-after-free
exploitable in Rust without doing a lot of careful alignment of data types in
the surrounding code.
The
tokio
featureio-util
is also required to be enabled to trigger thissoundness issue.
Thanks to zachs18 reporting the issue to Tokio team responsibly and taiki-e
and carllerche appropriately responding and fixing the soundness bug.
Tokio before 0.2.0 used
futures
0.1 that did not havePin
, so it is notaffected by this issue.
Release Notes
tokio-rs/tokio
v1.25.0
: Tokio v1.25.01.25.0 (January 28, 2023)
Fixed
Added
broadcast::Sender::len
(#5343)Changed
v1.24.1
: Tokio v1.24.1Compare Source
This release fixes a compilation failure on targets without
AtomicU64
when using rustc older than 1.63. (#5356)v1.24.0
: Tokio v1.24.0Compare Source
The highlight of this release is the reduction of lock contention for all I/O operations (#5300). We have received reports of up to a 20% improvement in CPU utilization and increased throughput for real-world I/O heavy applications.
Fixed
AtomicU64
support detection (#5284)Added
per tick (#5186)
threads per runtime instance (#4250)
Changed
read_dir()
by chunking operations (#5309)ThreadId
implementation (#5329)spawn_blocking
task is running (#5115)v1.23.1
: Tokio v1.23.1Compare Source
This release forward ports changes from 1.18.4.
Fixed
pipe mode (#5336).
v1.23.0
: Tokio v1.23.0Compare Source
Fixed
ChildStdin
(#5216)async fn ready()
false positive for OS-specific events (#5231)Changed
yield_now
defers task until after driver poll (#5223)winapi
dependency withwindows-sys
(#5204)Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.