Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JavaScript package manager configuration option 📦 #182

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add JavaScript package manager configuration option 📦 #182

wants to merge 1 commit into from

Conversation

jmackie
Copy link
Member

@jmackie jmackie commented Feb 8, 2023

Prompted by ditto-lang/todomvc#3

When using pnpm generated package.json files need to use the workspace protocol.

In order to support pnpm (and other package managers in the future) this needs to be configurable.

jmackie
jmackie commented Feb 8, 2023
View reviewed changes
crates/ditto-make/src/build_ninja.rs
format!("Generating package.json for {}", package_name.as_str()),
)]),
variables: HashMap::from_iter(vec![
(String::from("package-manager"), "pnpm".to_string()),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmackie