-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add record literals and field access ⏺️ #54
Conversation
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 79.45% 80.23% +0.77%
==========================================
Files 113 115 +2
Lines 7755 8352 +597
==========================================
+ Hits 6162 6701 +539
- Misses 1593 1651 +58
Continue to review full report at Codecov.
|
row: new_row, | ||
}) => { | ||
let t = Type::RecordOpen { | ||
kind: kind.clone(), // yeh? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nah 118fbec
Closes #11 and #53.
It made sense to implement both of these features at once as the implementation of one kinda informed the other. And it made testing easier.
Extensible records with scoped labels is essential reading. 👌