Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add record literals and field access ⏺️ #54

Merged
merged 10 commits into from
May 24, 2022
Merged

Add record literals and field access ⏺️ #54

merged 10 commits into from
May 24, 2022

Conversation

jmackie
Copy link
Member

@jmackie jmackie commented May 23, 2022

Closes #11 and #53.

It made sense to implement both of these features at once as the implementation of one kinda informed the other. And it made testing easier.

Extensible records with scoped labels is essential reading. 👌

@jmackie jmackie linked an issue May 23, 2022 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #54 (971fab6) into main (e3796fd) will increase coverage by 0.77%.
The diff coverage is 89.49%.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   79.45%   80.23%   +0.77%     
==========================================
  Files         113      115       +2     
  Lines        7755     8352     +597     
==========================================
+ Hits         6162     6701     +539     
- Misses       1593     1651      +58     
Impacted Files Coverage Δ
crates/ditto-checker/src/module/imports/mod.rs 90.51% <0.00%> (-1.19%) ⬇️
crates/ditto-checker/src/typechecker/env.rs 97.87% <ø> (ø)
crates/ditto-codegen-js/src/ast.rs 66.66% <ø> (ø)
...ates/ditto-codegen-js/tests/node_execution_test.rs 41.17% <ø> (ø)
crates/ditto-cst/src/syntax.rs 100.00% <ø> (ø)
crates/ditto-cst/src/type.rs 100.00% <ø> (ø)
crates/ditto-fmt/src/has_comments.rs 44.88% <31.25%> (-0.62%) ⬇️
crates/ditto-cst/src/get_span.rs 91.86% <62.50%> (-3.02%) ⬇️
crates/ditto-ast/src/type.rs 81.88% <81.13%> (-0.68%) ⬇️
crates/ditto-fmt/src/syntax.rs 80.15% <85.71%> (+1.39%) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3796fd...971fab6. Read the comment docs.

@jmackie jmackie merged commit fcc4450 into main May 24, 2022
@jmackie jmackie deleted the init-records branch May 24, 2022 07:04
row: new_row,
}) => {
let t = Type::RecordOpen {
kind: kind.clone(), // yeh?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah 118fbec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add record.access Add record literals {}
1 participant